Kanto:
Brock: (Anime) Pokemon Breeder; (Game) Occasional Fossil Digger
Misty: Swimmer
Lt. Surge: Is a pilot; was a soldier before
Erika: A student of the art of flower arranging
Koga (Former): Teacher of Ninjutsu
Janine: Ninja
Sabrina: Actress
Blaine: Scientist
Giovanni: Team Rocket Leader
Green: N/A; most likely too young to hold down a second job
Johto:
Falkner: N/A
Bugsy: An insect Pokemon researcher.
Whitney: N/A (making kids cry with her Milktank)
Morty: Studies and researches Legendary Pokemon related to the Towers of Ecruteak; also a seer
Chuck: N/A
Jasmine: Unofficial; takes care of Amphy at the lighthouse
Pryce: Retired from unknown job.
Clair: N/A.
Hoenn:
Roxanne: Teacher
Brawly: Martial Artist
Wattson: Founder of Mauville City, also town planner
Flannery: N/A
Norman: Negligent parent; call social services
Winona: (manga) Supervisor of all Hoenn Gym Leaders
Tate and Liza: N/A; likely too young
Wallace: Juan's pupil, runs the whole of Sootopolis.
Juan: Wallace's mentor/instructor, accomplished Pokemon co-ordinator
Sinnoh:
Roark: Excavator
Gardenia: N/A
Maylene: Martial Artist
Wake: A charitable man (uses the prize money he gets from competitive Pokémon battles to help the unfortunate. Just like Norman.)
Fantina: Contest Expert/Performer
Byron: Excavator
Candice: Teacher in Snowpoint City
Volkner: engineer; built the solar panel walkways in Sunnyshore City
Unova:
BW
Cilan, Chili and Cress: Run a Restaurant; they are waiters, cooks and tea connoisseurs.
Lenora: Archaeologist; librarian
Burgh: Artist
Elesa: Fashion model; also makes TV appearances
Clay: Businessman & miner
Skyla: Pilot
Brycen: Actor
Drayden: Mayor of Opelucid City and Iris' mentor
Iris: N/A; too young
B2W2
Cheren: Teacher
Roxie: Rockstar and singer
Marlon: Surfer-dude
Kalos:
Viola: Photographer
Grant: Athlete - rock climber
Korrina: Athlete - Rollerblader; guardian of Mega-evolution secrets; PR video star
Ramos: Gardener
Clemont: Inventor
Valerie: Designer and model from the Johto region
Olympia: N/A; possibly seer due to her psychic powers
Wulfric: Unofficial; takes care of the Pokemon in Pokemon village.
There are quiet a few (around Johto and Kalos) that I didn't quite get, post if you think I missed something.
As a matter of discrepancies, there are a few like Brock's role as a Breeder in the anime, which was not mentioned in the game, and Winona's job as supervisor in the manga.
Hope I helped!
