I am trying to chain fish for a shiny Pokemon with my cradily at the front of the party, during a battle, it fainted, will suction cups's higher fishing rate work?
Yes, it will. Regardless if a Pokemon is fainted or not, abilities that have an effect outside of battle (like Suction Cups or Synchronize) will always work. This is similar to fainted Pokemon using HM moves.
Source: Experience