I took advantage of the sun and moons way of getting the shiny charm, and I have it, but how does it work? Like, does the Pokémon battling have to hold it?
The shiny charm is a key item, so it can't be a held item at all. Once you get it, its effect is simply always active from then on, with no need to do anything special to invoke it.